This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Add doc-viewer component #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinayuangao
reviewed
Nov 21, 2016
| @@ -2,3 +2,4 @@ | |||
| <img src="../../../assets/img/components/{{component.src}}.svg" [alt]="component.name" /> | |||
| {{component.name}} | |||
| </div> | |||
| <doc-viewer documentUrl="/assets/documents/README.html"></doc-viewer> | |||
There was a problem hiding this comment.
nit: I think we usually use document-url and use @Input('document-url') in typeScript file
There was a problem hiding this comment.
That's what I had originally, but @jelbourn suggested I change it to this
| error => { | ||
| console.log(error); | ||
| this._elementRef.nativeElement.innerText = | ||
| `Failed to load document: ${url}. Error: ${error}`; |
|
@jelbourn @tinayuangao is src/app/shared going to be the official home of our components? |
|
@mmalerba |
|
tests working (though I wasn't able to tests for the |
|
LGTM, just needs rebase |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.