This repository was archived by the owner on Dec 18, 2024. It is now read-only.
feat: Prepare for adding CDK docs #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
force-pushed
the
cdk
branch
4 times, most recently
from
726621e to
107507f
Compare
jelbourn
reviewed
Sep 14, 2017
| import {SECTIONS} from '../../shared/documentation-items/documentation-items'; | ||
|
|
||
| @Injectable() | ||
| export class CanActivateComponentSidenav implements CanActivate { |
| constructor(private router: Router) {} | ||
|
|
||
| canActivate(route: ActivatedRouteSnapshot, state: RouterStateSnapshot) { | ||
| let sectionFound = Object.keys(SECTIONS).find( |
There was a problem hiding this comment.
Add comment explaining what this is doing? E.g. Prevent navigation to a section if...
|
|
||
| ngOnInit() { | ||
| this._componentPageTitle.title = 'Component Categories'; | ||
| this.params = Observable.combineLatest( |
| 'components': 'Components', | ||
| }; | ||
| const CDK = 'cdk'; | ||
| const COMPONENTS = 'components'; |
There was a problem hiding this comment.
Is it worthwhile to have these as constants?
josephperrott
force-pushed
the
cdk
branch
2 times, most recently
from
1d199fc to
0ebe8a8
Compare
josephperrott
force-pushed
the
cdk
branch
5 times, most recently
from
7ef8532 to
0b6c07a
Compare
|
@jelbourn This is ready for review once more. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#243