This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Expand component view with example viewer #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, I have an updated version of the button (and other) examples, but we can always update those in a follow up pr |
tinayuangao
reviewed
Dec 19, 2016
| * The list of all example components. | ||
| * We need to put them in both `declarations` and `entryComponents` to make them work. | ||
| */ | ||
| export const EXAMPLE_LIST = [ |
There was a problem hiding this comment.
get the list from EXAMPLE_COMPONENT so we don't have to write them twice?
There was a problem hiding this comment.
We can't- doing that would be incompatible with AoT because the values have to be static constants.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocumentationItemsserviceComponentViewsidenavExampleViewerI want to get this PR in so that @amitafr can start working on styles. Currently working on unit tests for
ExampleViewer