Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Sidenav styles #34

Merged
merged 5 commits into from
Dec 21, 2016
Merged

Sidenav styles #34

merged 5 commits into from
Dec 21, 2016

Conversation

alexwolfe
Copy link
Contributor

@jelbourn (cc/ @naomiblack, @amitafr )

Ok, sidenav styles are ready for review.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment. I tried out the changes and they look fantastic. Thanks!

}
// SETTINGS

$unit: 8px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment for what $unit and $layer represent?

@jelbourn
Copy link
Member

Added an additional commit to this PR with some small refactoring

Copy link
Collaborator

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 16f8fa2 into master Dec 21, 2016
@jelbourn jelbourn deleted the sidenav-styles branch April 24, 2018 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants