fix: errors in plunkr template #54
Conversation
* Fixes errors in the Plunkr template due to outdated Material version. * Updates the outdated theme link. * Disables the opening of the Plunk in a new tab, because it gets blocked by the browser as a popup. This is based on the Plunkr from our issue template.
|
@jelbourn a couple of notes:
|
| @@ -23,10 +23,9 @@ | |||
| </script> | |||
|
|
|||
| <!-- Load the Angular Material 2 stylesheet --> | |||
| <link href="https://unpkg.com/@angular/material/core/theming/prebuilt/indigo-pink.css" rel="stylesheet"> | |||
|
|
|||
| <link href="https://cdn.rawgit.com/angular/material2-builds/master/core/theming/prebuilt/indigo-pink.css" rel="stylesheet"> | |||
There was a problem hiding this comment.
Using the CDN for rawgit when loading the master branch may cause issues.
See rgrove/rawgit#51
| '@angular/router': 'http://unpkg.com/@angular/router/bundles/router.umd.js', | ||
| '@angular/platform-browser': 'http://unpkg.com/@angular/platform-browser/bundles/platform-browser.umd.js', | ||
| '@angular/platform-browser-dynamic': 'http://unpkg.com/@angular/platform-browser-dynamic/bundles/platform-browser-dynamic.umd.js', | ||
| '@angular/material': 'https://cdn.rawgit.com/angular/material2-builds/master/bundles/material.umd.js', |
There was a problem hiding this comment.
Same here with the cdn. (rgrove/rawgit#51)
| @@ -27,7 +27,7 @@ System.config({ | |||
| '@angular/router': 'http://unpkg.com/@angular/router/bundles/router.umd.js', | |||
| '@angular/platform-browser': 'http://unpkg.com/@angular/platform-browser/bundles/platform-browser.umd.js', | |||
| '@angular/platform-browser-dynamic': 'http://unpkg.com/@angular/platform-browser-dynamic/bundles/platform-browser-dynamic.umd.js', | |||
| '@angular/material': 'https://cdn.rawgit.com/angular/material2-builds/master/bundles/material.umd.js', | |||
| '@angular/material': 'https://unpkg.com/@angular/material/core/theming/prebuilt/indigo-pink.css', | |||
There was a problem hiding this comment.
This should be actually the .umd bundle 😄
|
LGTM |
This is based on the Plunkr from our issue template.