fix(plunker): make calls to plunker synchronous to avoid popup block #83
Conversation
| * The button becomes disabled if the user hovers over the button before the plunker form | ||
| * is created. After the form is created, the button becomes enabled again. | ||
| */ | ||
| isDisabled: boolean = false; |
There was a problem hiding this comment.
Should we make it disabled by default?
There was a problem hiding this comment.
Initially I had it disabled by default and only enabled when the form was created. However, this caused a bit of a flicker on the button where it goes from disabled -> enabled right after the page loads.
With the current implementation, it always appears active to the user except in the small chance they manage to mouse over it to interact with it. In which case, it disables itself and shows a tooltip saying that we building the form.
|
|
||
| @Input() | ||
| set example(example: string) { | ||
| this.exampleData = new ExampleData(example); | ||
| const exampleData = new ExampleData(example); | ||
| this.plunkerWriter.constructPlunkerForm(exampleData).then(plunkerForm => { |
There was a problem hiding this comment.
Add something like "This usually happens extremely quickly, but we handle the case of the plunker not yet being ready for people will poor network connections or slow devices."
|
Added a comment about the speed of creating the form |
No description provided.