Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 1c098a6

Browse files
crisbetojelbourn
authored andcommitted
fix(datepicker, menu, slider): remove duplicate properties (#9335)
* Reworks the `md-calendar-cell` mixin to allow for the height to be specified, avoiding the need for a duplicate property when overriding. * Removes the `text-align: start` from the menu bar since, at least according to MDN, it's not supported by IE. Also the rtl mixin right before it does exactly the same. * Reworks the rtl setup for the inverted slider so it doesn't result in duplicate properties.
1 parent 45d7b77 commit 1c098a6

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/components/datepicker/calendar.scss

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@ $md-calendar-height:
1515
($md-calendar-weeks-to-show * $md-calendar-cell-size) + $md-calendar-header-height !default;
1616

1717
// Styles for date cells, including day-of-the-week header cells.
18-
@mixin md-calendar-cell() {
19-
height: $md-calendar-cell-size;
18+
@mixin md-calendar-cell($height: $md-calendar-cell-size) {
19+
height: $height;
2020
width: $md-calendar-cell-size;
21-
2221
text-align: center;
2322

2423
// Remove all padding and borders so we can completely
@@ -146,9 +145,8 @@ md-calendar {
146145
@include md-calendar-table();
147146

148147
th {
149-
@include md-calendar-cell();
148+
@include md-calendar-cell($md-calendar-header-height);
150149
font-weight: normal;
151-
height: $md-calendar-header-height;
152150
}
153151
}
154152

src/components/menuBar/menu-bar.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ md-menu-content.md-menu-bar-menu.md-dense {
6666

6767
md-menu-item > .md-button, .md-menu > .md-button {
6868
@include rtl(text-align, left, right);
69-
text-align: start;
7069
}
7170

7271
.md-menu {

src/components/slider/slider.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,8 +427,8 @@ md-slider {
427427
}
428428
&[md-invert] {
429429
&:not([md-vertical]) .md-track-fill {
430-
@include rtl-prop(left, right, auto, auto);
431-
@include rtl-prop(right, left, 0, auto);
430+
@include rtl(left, auto, 0);
431+
@include rtl(right, 0, auto);
432432
}
433433
&[md-vertical] {
434434
.md-track-fill {

0 commit comments

Comments
 (0)