Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(datepicker, menu, slider): remove duplicate properties #9335

Merged
merged 1 commit into from
Aug 23, 2016

Conversation

crisbeto
Copy link
Member

  • Reworks the md-calendar-cell mixin to allow for the height to be specified, avoiding the need for a duplicate property when overriding.
  • Removes the text-align: start from the menu bar since, at least according to MDN, it's not supported by IE. Also the rtl mixin right before it does exactly the same.
  • Reworks the rtl setup for the inverted slider so it doesn't result in duplicate properties.

* Reworks the `md-calendar-cell` mixin to allow for the height to be specified, avoiding the need for a duplicate property when overriding.
* Removes the `text-align: start` from the menu bar since, at least according to MDN, it's not supported by IE. Also the rtl mixin right before it does exactly the same.
* Reworks the rtl setup for the inverted slider so it doesn't result in duplicate properties.
@crisbeto crisbeto added the needs: review This PR is waiting on review from the team label Aug 18, 2016
@ThomasBurleson ThomasBurleson added the pr: merge ready This PR is ready for a caretaker to review label Aug 18, 2016
@ThomasBurleson
Copy link
Contributor

lgtm

@ThomasBurleson ThomasBurleson removed the needs: review This PR is waiting on review from the team label Aug 18, 2016
@ThomasBurleson ThomasBurleson added this to the 1.1.1 milestone Aug 18, 2016
@jelbourn jelbourn merged commit 1c098a6 into angular:master Aug 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants