Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(datepicker): Fix validation in IE. #10520

Closed
wants to merge 2 commits into from
Closed

fix(datepicker): Fix validation in IE. #10520

wants to merge 2 commits into from

Conversation

topherfangio
Copy link
Contributor

Adds in validation for the input as a last check as IE interpreted the date '11/14/2016d' as valid which is incorrect.

Note: This PR supersedes #10015 by adding a test.

Fixes #9994. Closes #10015.

@topherfangio topherfangio added the needs: review This PR is waiting on review from the team label Mar 20, 2017
@topherfangio topherfangio self-assigned this Mar 20, 2017
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Mar 20, 2017
@richardhughes
Copy link

Hey @topherfangio, Looks good to me, I've just noticed that Google Bot has put a message on this to get confirmation.

I couldn't get the test runner to work in the end, but that was down to my old development machine.

@topherfangio topherfangio added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Apr 7, 2017
@topherfangio
Copy link
Contributor Author

@richardhughes Thanks! I've marked it as cla: yes since you approved it. Thomas should review it when he has a chance, but he and much of the team is at ngConf right now, so it will likely happen after they return.

@ThomasBurleson
Copy link
Contributor

@topherfangio - can you squash your commits.

@ThomasBurleson ThomasBurleson added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label May 8, 2017
@ThomasBurleson ThomasBurleson added this to the 1.1.5 milestone May 8, 2017
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.5, 1.1.6 Sep 5, 2017
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar Splaktar added severity: regression This issue is related to a regression browser: IE This issue is specific to Internet Explorer P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Feb 7, 2018
@Splaktar Splaktar requested review from Splaktar and crisbeto and removed request for ThomasBurleson February 7, 2018 05:21
@Splaktar Splaktar self-assigned this Feb 7, 2018
@angular angular deleted a comment from googlebot Feb 7, 2018
Splaktar
Splaktar suggested changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than commits needing to be squashed and fixed to conform to commit rules.

Splaktar added a commit that referenced this pull request Feb 7, 2018
@Splaktar
fix(datepicker): validation error when adding text after date
f280ef6 
this fixes a regression introduced in v1.1.0 against IE
however the test is able to reproduce the issue on Chrome
thank you to Topher Fangio and Richard Hughes for the original solution

Fixes #9994. Closes #10520. Relates to #10015.
@Splaktar Splaktar mentioned this pull request Feb 7, 2018
Merged
3 tasks
@Splaktar
Copy link
Contributor

Splaktar commented Feb 7, 2018

Closing this in favor of #11110 since the request to squash commits was not resolved.

@Splaktar Splaktar closed this Feb 7, 2018
@Splaktar Splaktar removed this from the 1.1.7 milestone Feb 7, 2018
@Splaktar Splaktar removed the needs: review This PR is waiting on review from the team label Feb 7, 2018
mmalerba pushed a commit that referenced this pull request Jan 4, 2019
@Splaktar @mmalerba
fix(datepicker): validation error when adding text after date (#11110)
57c81c8 
## PR Checklist
Please check that your PR fulfills the following requirements:

- [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format)
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)

## PR Type
What kind of change does this PR introduce?
```
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:
```

## What is the current behavior?
this fixes a regression introduced in v1.1.0 against IE
however the test is able to reproduce the issue on Chrome

Issue Number: 
Fixes #9994. Closes #10520. Relates to #10015.

## What is the new behavior?
The test passes and datepicker validation and ngMessages work properly on IE.

## Does this PR introduce a breaking change?
```
[ ] Yes
[x] No
```

## Other information
thank you to Topher Fangio and Richard Hughes for the original solution
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

1 more reviewer

@Splaktar Splaktar Splaktar requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Splaktar Splaktar

Labels
browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@topherfangio @googlebot @richardhughes @ThomasBurleson @Splaktar