Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(layout): reduce layout size and fix flex 33/66 outside of layout containers #11331

Merged
merged 1 commit into from
Jun 19, 2018
Merged

fix(layout): reduce layout size and fix flex 33/66 outside of layout containers #11331

merged 1 commit into from
Jun 19, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Layout CSS size increased by 78 KB in 1.1.9.

Issue Number:
Fixes #11000. Relates to #9546.

What is the new behavior?

Reduces unminified layout CSS size by ~77KB by reverting some of #11247.
Adds support for flex="33" and flex="66" outside of a layout attribute just like all of the other flex directives like 0, 5, ... 100.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Reducing this size is critical for syncing the latest master into Google.

@Splaktar
fix(layout): reduce layout CSS size by reverting some of #11247
617b139 
reduces unminified layout CSS size by ~77KB

Fixes #11000. Relates to #9546.
@Splaktar Splaktar added type: bug type: docs ui: layout severity: performance This issue causes a significant performance degradation g3: reported The issue was reported by an internal or external product team. P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Jun 18, 2018
@Splaktar Splaktar added this to the 1.1.10 milestone Jun 18, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 18, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jun 18, 2018
jelbourn
jelbourn approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 5e37b63 into master Jun 19, 2018
@Splaktar Splaktar deleted the reduceLayoutSize branch June 19, 2018 22:37
Splaktar added a commit that referenced this pull request Jul 31, 2018
@Splaktar
fix(layout): reduce layout CSS size by reverting some of #11247 (#11331)
98b52d7 
reduces unminified layout CSS size by ~77KB

Fixes #11000. Relates to #9546.
@Splaktar Splaktar mentioned this pull request Jan 28, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@Splaktar Splaktar

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: performance This issue causes a significant performance degradation type: bug type: docs ui: layout
Projects
None yet
Milestone
1.1.10
Development

Successfully merging this pull request may close these issues.

layout: flex-33 and flex-66 don't work with layout-gt-xs, layout-gt-md, etc.
3 participants
@Splaktar @jelbourn @googlebot