-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(layout): some flex directives don't work when on a child of layout="column" or layout="row" #11247
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
I reviewed the primary changes to the SCSS in #10797 and they LGTM. This PR just adds some whitespace cleanup and clarification to some comments. |
…t="column" or layout="row" (angular#11247) * fix(layout): add missing media query overrides The current implementation's CSS rules did not properly override other rules when using @media sizes. * Add SCSS rules for flex-0 to flex-100 * Add SCSS rules for flex-33 and flex-66 Fixes angular#9546 * style(layout): clean up whitespace and comments
…t="column" or layout="row" (#11247) * fix(layout): add missing media query overrides The current implementation's CSS rules did not properly override other rules when using @media sizes. * Add SCSS rules for flex-0 to flex-100 * Add SCSS rules for flex-33 and flex-66 Fixes #9546 * style(layout): clean up whitespace and comments
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some flex directives don't work when on a child of
layout="column"
orlayout="row"
. This includesflex="0"
,flex="33"
,flex="66"
,flex="100"
.Issue Number:
Fixes #9546
What is the new behavior?
flex="0"
,flex="33"
,flex="66"
,flex="100"
now behave properly when applied to an element that is a child of an element withlayout="column"
orlayout="row"
.Does this PR introduce a breaking change?
Other information
Relates to and includes contents of PR #10797.