Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

tabs: elements variable in MdTabsController is no longer referenced #11377

@NgMomentum

Description

@NgMomentum

Bug, enhancement request, or proposal:

Small correction or update to MdTabsController controller.

CodePen and steps to reproduce the issue:

CodePen Demo which demonstrates the issue:

Not applicable.

Detailed Reproduction Steps:

What is the expected behavior?

Variable not needed.

What is the current behavior?

Variable is defined and no longer used.

What is the use-case or motivation for changing an existing behavior?

Clarification of code or to minimize ambiguity.

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: all
  • AngularJS Material: v1.1.10
  • OS: any
  • Browsers: any

Is there anything else we should know? Stack Traces, Screenshots, etc.

Not applicable

The variable "elements" as written "elements = getElements()," in the MdTabsController is no longer needed. That is, it is defined, initialized and updated in the MdTabsController controller, but is no longer used because each subroutine function calls its own "elements" variable anyway. Looks to be leftover code, but of coarse, that is for you guys to decide. This is just a heads up that there is a confusing use of "elements" here, nothing more.

Metadata

Metadata

Assignees

Labels

P5: nice to haveThese issues will not be fixed without community contributions.has: Pull RequestA PR has been created to address this issueresolution: fixedtype: performanceThis issue is related to performance

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions