This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(nav-bar): update keyboard navigation to WAI-ARIA guidelines #11494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Oct 26, 2018
Splaktar
force-pushed
the
improveNavBarKeyboardNav
branch
from
5059cc1
to
6752cce
Compare
- stop blocking shift-tab from moving focus away from the nav-bar - enable the use of the home and end keys - wrap to the first/last tab when hitting the end - properly manage nav item tabindex values - skip over disabled tabs instead of leaving focus in a bad state - remove click listener on destroy - document keyboard behaviors - fix bad linking syntax in API docs - update to latest karma version Fixes #10419. Relates to #11489.
Splaktar
force-pushed
the
improveNavBarKeyboardNav
branch
from
6752cce
to
d06e6f2
Compare
marosoft
pushed a commit
to marosoft/material
that referenced
this pull request
Nov 11, 2018
…lar#11494) - stop blocking shift-tab from moving focus away from the nav-bar - enable the use of the home and end keys - wrap to the first/last tab when hitting the end - properly manage nav item tabindex values - skip over disabled tabs instead of leaving focus in a bad state - remove click listener on destroy - document keyboard behaviors - fix bad linking syntax in API docs - update to latest karma version Fixes angular#10419. Relates to angular#11489.
3 tasks
mmalerba
pushed a commit
that referenced
this pull request
Feb 1, 2019
<!-- Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed. --> ## PR Checklist Please check that your PR fulfills the following requirements: - [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format) - [x] Tests for the changes have been added or this is not a bug fix / enhancement - [x] Docs have been added, updated, or were not required ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Enhancement [ ] Documentation content changes [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Infrastructure changes [ ] Other... Please describe: ``` ## What is the current behavior? Clicking on nav items with a mouse causes the focus to move to the previously clicked nav item instead of the newly clicked nav item. <!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. --> Issue Number: Fixes #11591. Relates to #11494. Closes #11598. ## What is the new behavior? - Focus is moved to the new nav item after it is clicked. - remove hover style that is inconsistent with spec - add test from @codymikol ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ``` <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. --> ## Other information Thank you to @codymikol for doing the initial investigation into this regression!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
md-nav-barwith shift+tab on keyboard.md-nav-barinstead of being properly forwarded to the._md-nav-buttoncausing the arrow buttons and keyboard navigation to not work.Issue Number:
Fixes #10419. Relates to #11489.
What is the new behavior?
Update keyboard navigation to WAI-ARIA guidelines
Does this PR introduce a breaking change?
Other information
These changes have been tested with #11486 and they are compatible with those changes. This PR should be merged after #11486.