This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): updateSize incorrectly sets the size to zero #11500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In some cases, like resizing the page, updateSize incorrectly sets the size to zero.
This can break the ability to show the dropdown on focus.
Issue Number:
Fixes #10834
What is the new behavior?
Check that the size value isn't zero before setting the size.
Does this PR introduce a breaking change?
Other information
Manually tested as I wasn't sure how to resize the browser in a unit test.