Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Nov 1, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In some cases, like resizing the page, updateSize incorrectly sets the size to zero.
This can break the ability to show the dropdown on focus.

Issue Number:
Fixes #10834

What is the new behavior?

Check that the size value isn't zero before setting the size.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Manually tested as I wasn't sure how to resize the browser in a unit test.

this can break the ability to show the dropdown on focus

Fixes #10834
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Nov 1, 2018
@Splaktar Splaktar self-assigned this Nov 1, 2018
@Splaktar Splaktar added type: bug P4: minor Minor issues. May not be fixed without community contributions. labels Nov 1, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Nov 1, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Nov 1, 2018
@Splaktar Splaktar assigned jelbourn and unassigned Splaktar Nov 1, 2018
@jelbourn jelbourn merged commit d343363 into master Nov 6, 2018
@Splaktar Splaktar deleted the autocomplete-fix-updateSize branch November 7, 2018 18:33
marosoft pushed a commit to marosoft/material that referenced this pull request Nov 11, 2018
…lar#11500)

this can break the ability to show the dropdown on focus

Fixes angular#10834
@andrewseguin
Copy link
Contributor

Reverting this change because it broke some internal tests. It seems that the behavior is now changed so that re-evaluating the size changes the element height through setSize.

@Splaktar
Copy link
Contributor Author

Fixed the regression caused by this issue in #11518.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete: suggestions don't show after $md-resize raised while something is selected
4 participants