Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

innerHTML is not supported on svg or symbol elements in IE11.
Two exceptions as described in the linked issue.

Issue Number:
Fixes #11543. Relates to #11342. Relates to #11162.

What is the new behavior?

Use XMLSerializer instead when innerHTML is not defined.
No more exceptions.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Fix inspired by https://stackoverflow.com/a/45460931/633107.

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 17, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Dec 17, 2018
@Splaktar Splaktar self-assigned this Dec 17, 2018
@Splaktar Splaktar added type: bug pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression P1: urgent Urgent issues that should be addressed in the next minor or patch release. browser: IE This issue is specific to Internet Explorer labels Dec 17, 2018
@Splaktar Splaktar force-pushed the icon-fixIERegressions branch from e0840bd to fce2b02 Compare December 20, 2018 19:12
innerHTML is not supported on svg or symbol elements in IE11
use XMLSerializer instead of innerHTML when innerHTML is not defined
add a test for empty SVGs to match a g3 test

Fixes #11543. Relates to #11342. Relates to #11162.
@Splaktar Splaktar force-pushed the icon-fixIERegressions branch from fce2b02 to acb5324 Compare December 20, 2018 19:34
@jelbourn jelbourn merged commit 47527f2 into master Dec 20, 2018
@Splaktar Splaktar deleted the icon-fixIERegressions branch December 20, 2018 21:33
Splaktar added a commit that referenced this pull request Feb 9, 2019
preserve the outer SVG element and its attributes

Fixes #11603. Relates to #11545. Closes #11604.
Splaktar added a commit that referenced this pull request Feb 11, 2019
preserve the outer SVG element and its attributes

Fixes #11603. Relates to #11545. Closes #11604.
jelbourn pushed a commit that referenced this pull request Feb 13, 2019
#11635)

preserve the outer SVG element and its attributes

Fixes #11603. Relates to #11545. Closes #11604.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icon: unable to get property 'replace' of undefined or null reference at transformClone
4 participants