Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(icon): SVG elements are not loaded from the cache properly on IE11 #11635

Merged
merged 1 commit into from
Feb 13, 2019
Merged

fix(icon): SVG elements are not loaded from the cache properly on IE11 #11635

merged 1 commit into from
Feb 13, 2019

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Feb 9, 2019 •
edited
Loading

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

SVG elements are not loaded from the cache properly on IE11. The outer <svg> tag is lost.

Issue Number:
Fixes #11603. Relates to #11545. Closes #11604.

What is the new behavior?

SVG elements are loaded from the cache properly on IE11 including the <svg> tag and the element's attributes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

We can't just use outerHTML here either due to that not being supported for SVG elements in IE as well.

@Splaktar Splaktar self-assigned this Feb 9, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Feb 9, 2019
@Splaktar Splaktar added this to the 1.1.13 milestone Feb 9, 2019
@Splaktar Splaktar added type: bug severity: regression This issue is related to a regression P1: urgent Urgent issues that should be addressed in the next minor or patch release. browser: IE This issue is specific to Internet Explorer labels Feb 9, 2019
@Splaktar Splaktar requested a review from jelbourn February 9, 2019 01:03
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Feb 9, 2019
@Splaktar Splaktar mentioned this pull request Feb 9, 2019
Closed
3 tasks
jelbourn
jelbourn reviewed Feb 11, 2019
View reviewed changes
@Splaktar
fix(icon): SVG elements are not loaded from the cache properly on IE11
59e8c3c 
preserve the outer SVG element and its attributes

Fixes #11603. Relates to #11545. Closes #11604.
@Splaktar Splaktar force-pushed the icon-fixCacheXssSafeIE11 branch from 0c67497 to 59e8c3c Compare February 11, 2019 20:05
@Splaktar Splaktar assigned jelbourn and unassigned jelbourn and josephperrott Feb 11, 2019
jelbourn
jelbourn approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 7cde443 into master Feb 13, 2019
@Splaktar Splaktar deleted the icon-fixCacheXssSafeIE11 branch February 13, 2019 08:46
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Feb 13, 2019
Merged
3 tasks
@Splaktar Splaktar mentioned this pull request Feb 25, 2019
Closed
Splaktar added a commit that referenced this pull request Feb 25, 2019
@Splaktar
fix(icon): large SVG files can cause icon caching to hang
a4f6ab5 
use querySelectorAll as much as possible
reduce the use of RegEx on large chunks of DOM

Fixes #11651. Relates to #8689. Relates to #11342. Relates to #11635.
@Splaktar Splaktar mentioned this pull request Feb 25, 2019
Merged
3 tasks
Splaktar added a commit that referenced this pull request Feb 25, 2019
@Splaktar
fix(icon): large SVG files can cause icon caching to hang
46563a5 
use querySelectorAll as much as possible
reduce the use of RegEx on large chunks of DOM

Fixes #11651. Relates to #8689. Relates to #11342. Relates to #11635.
Splaktar added a commit that referenced this pull request Mar 1, 2019
@Splaktar
fix(icon): large SVG files can cause icon caching to hang
132a575 
use querySelectorAll as much as possible
reduce the use of RegEx on large chunks of DOM

Fixes #11651. Relates to #8689. Relates to #11342. Relates to #11635.
Splaktar added a commit that referenced this pull request Mar 1, 2019
@Splaktar
fix(icon): large SVG files can cause icon caching to hang
63ba492 
use querySelectorAll as much as possible
reduce the use of RegEx on large chunks of DOM

Fixes #11651. Relates to #8689. Relates to #11342. Relates to #11635.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jelbourn jelbourn jelbourn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jelbourn jelbourn

@Splaktar Splaktar

Labels
browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Milestone
1.1.13
Development

Successfully merging this pull request may close these issues.

icon: SVG icons disappear in IE11 when reused from internal cache
4 participants
@Splaktar @jelbourn @googlebot @josephperrott