-
Notifications
You must be signed in to change notification settings - Fork 3.4k
build: npm package for v1.1.14-v1.1.16 contains .git folder #11684
Comments
We don't use @mmalerba can you please let us know what version of NPM was used for |
node |
The last 4 releases were created by @mmalerba and @jelbourn. The There is an abandoned npm bug where However, this npm blog post on npm publish clearly states that
The NPM blog post also suggests that we not use This clearly looks like a bug in NPM. @mmalerba since you are the only one who can investigate this further or report it, can you please report this to NPM? We'll also need to get another release out soon that doesn't include this |
Before we do the release to fix this, we should use the |
same problem here, new version contains .git folder |
We're planning to put out the |
Same here, 1.1.14 has .git in it's npm package. Causing future Downgrading to 1.1.13 by setting this config in package.json: |
@Splaktar in addition to what you mention, these are some extra details:
https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package I could not see any .npmignore file in the repo. At the same time two files in the git ignored dist folder are published into npm. |
@marosoft it just looks to be a bug with NPM on Linux. It's worked every other time. Changing our config adds risk of another bad release. I think that we'll just try to release from macOS until the NPM issue on Linux gets resolved. |
Maybe this is related? Or this: |
We've decided to investigate a change to the release script so that we never publish from the root of the repo (which we do now). |
Had the sample problem installing |
1.1.15 was just released, from a Linux machine again, and we have successfully reproduced this problem |
Hopefully a fixed |
|
1.1.17 has been released and it does not include the It looks like it was publishing the Possible workarounds for the future
|
Thanks @Splaktar, that seems to work for me. I was able to update from 1.1.13 -> 1.1.17 without the dreaded |
After looking into this some more, and editing my previous comment, it looks like solution 2 is the most likely to succeed and avoid any side effects. |
Bug, enhancement request, or proposal:
Bug
Detailed Reproduction Steps:
What is the expected behavior?
there is no .git folder
What is the current behavior?
there is a .git folder
What is the use-case or motivation for changing an existing behavior?
npm doesn't like having sub modules or repos in the node_modules folder, and complains with the following error
npm ERR! git {myproject}\node_modules\angular-material: Appears to be a git repo or submodule.
npm ERR! git {myproject}\node_modules\angular-material
npm ERR! git Refusing to remove it. Update manually,
npm ERR! git or move it out of the way first.
Which versions of AngularJS, Material, OS, and browsers are affected?
Is there anything else we should know? Stack Traces, Screenshots, etc.
The text was updated successfully, but these errors were encountered: