Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

npm publish publishes the .git/ directory in our release directory (./bower-material/) during the release process.

Issue Number:
Fixes #11684

What is the new behavior?

The ./bower-material/.git/ directory is removed before doing npm publish.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This needs to be merged before the next release (1.1.18).

@Splaktar Splaktar added type: bug type: chore severity: regression This issue is related to a regression P2: required Issues that must be fixed. labels Mar 30, 2019
@Splaktar Splaktar added this to the 1.1.18 milestone Mar 30, 2019
@Splaktar Splaktar self-assigned this Mar 30, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 30, 2019
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Mar 30, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit f44b271 into master Apr 1, 2019
@Splaktar Splaktar deleted the release-fixNpmPublish branch April 1, 2019 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: npm package for v1.1.14-v1.1.16 contains .git folder
3 participants