Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(icon): Log network errors without throwing exceptions. #3718

Closed
wants to merge 1 commit into from
Closed

fix(icon): Log network errors without throwing exceptions. #3718

wants to merge 1 commit into from

Conversation

programmist
Copy link
Contributor

fixes #2530

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ThomasBurleson ThomasBurleson added needs: review This PR is waiting on review from the team needs: tests labels Jul 14, 2015
@ThomasBurleson
Copy link
Contributor

@programmist - needs some unit tests for these, plz.

@ThomasBurleson ThomasBurleson modified the milestone: 0.10.1-rc2 Jul 15, 2015
@programmist
Copy link
Contributor Author

@ThomasBurleson Test added.

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Aug 17, 2015
kennethcachia pushed a commit to kennethcachia/material that referenced this pull request Sep 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-icon: Gracefully handle network errors
5 participants