Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix(select): text-align:end is not supported in IE #3840

Closed
wants to merge 3 commits into from
Closed

fix(select): text-align:end is not supported in IE #3840

wants to merge 3 commits into from

Conversation

prestonvanloon
Copy link

text-align: end is not supported by some browsers. This can cause improper positioning of the md-select-icon

https://developer.mozilla.org/en-US/docs/Web/CSS/text-align

Fixes #2213

@clshortfuse
Copy link
Contributor

Using right instead of end would conflict with right-to-left languages.

@prestonvanloon
Copy link
Author

Good point, I updated to use the RTL selector

@ThomasBurleson
Copy link
Contributor

@prestonvanloon - you should probably change this also;

@include rtl(align-items, flex-end, flex-start);

@ThomasBurleson ThomasBurleson added this to the 0.11.0 milestone Jul 22, 2015
@ThomasBurleson ThomasBurleson added ui: layout i18n: bi-directional This issue is related to internationalization and right to left languages browser: IE This issue is specific to Internet Explorer labels Jul 22, 2015
@ThomasBurleson ThomasBurleson self-assigned this Jul 22, 2015
@prestonvanloon
Copy link
Author

@ThomasBurleson - agreed

@naomiblack naomiblack modified the milestones: 0.12.0, 0.11.0 Aug 14, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.11.0, 0.12.0 Aug 20, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.12, 0.13 Oct 15, 2015
@prestonvanloon
Copy link
Author

I think this has been resolved elsewhere

@Splaktar
Copy link
Member

This was tweaked in 70c0c6e, but that only made the carrot not show up under the text. It didn't fix the left-to-right alignment.

This is still a problem as noted in #10714.

Splaktar added a commit that referenced this pull request Dec 15, 2018
@clshortfuse
Copy link
Contributor

It's a bit confusing, but it seems what happened was that this PR was closed by the creator and never merged. It would have solved the issue properly. The second commit that came later in August was a partial fix, but that was a direct commit without a PR and wasn't reviewed.

mmalerba pushed a commit that referenced this pull request Jan 7, 2019
<!-- 
Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed.
-->
## PR Checklist
Please check that your PR fulfills the following requirements:
- [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format)
- [ ] Tests for the changes have been added or this is not a bug fix / enhancement
- [x] Docs have been added, updated, or were not required

## PR Type
What kind of change does this PR introduce?
<!-- Please check the one that applies to this PR using "x". -->
```
[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:
```

## What is the current behavior?
Carrots in `md-select`s are not aligned to the end in IE11 as explained in the issue.
<!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. -->
Issue Number: 
Fixes #10714. Relates to #3840.

## What is the new behavior?
Carrots are properly positioned in IE11, Edge, Chrome, and Firefox.

## Does this PR introduce a breaking change?
```
[ ] Yes
[x] No
```
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
<!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. -->

## Other information
Thank you to @prestonvanloon for the original fix here in #3840.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: IE This issue is specific to Internet Explorer i18n: bi-directional This issue is related to internationalization and right to left languages ui: layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants