Impossible to resolve a dialog with a boolean (always returns true)

[glebm]

This is due to this line in interimElement:

material/src/core/services/interimElement/interimElement.js

Line 314 in d9ba0e1

.remove(reason || SHOW_CLOSED, false)

(and L339):

.remove(reason || SHOW_CLOSED, false)

Instead of using || this should check for undefined.

[dmackerman]

Couldn't you just use .cancel() on the mdDialog instance to return false?

[glebm]

This is not what cancel does. Cancel indicates cancellation, not resolution.

Imagine an unsaved changes dialog that triggers on some action, with three buttons:

You have unsaved changes.

• Cancel or click outside the dialog: cancel()
• Exit without saving: resolve(false)
• Save and exit: resolve(true)

This bug can be worked around of course (e.g. by passing an object with a boolean inside), but it is still a bug. This is also a regression, as it used to work a few months ago, though it is tough to pinpoint the exact commit that broke it due to the multiple reformats of that file.

[dmackerman]

Why is "Exit without saving" any different than "Cancel"? Am I missing something?

[glebm]

"Exit without saving" reverts the changes and exits. "Cancel" does not revert the changes and does not exit.

[ThomasBurleson]

Cancel should resolve the Dialog promise with "false".

[glebm]

Shouldn't cancel reject the promise? Updated the description to clarify what the bug is.

[mighe]

Same issue here.
I agree that most of the times we can use cancel to get the desired behaviour, but we also expect that the every parameter passed to the $hide function will be found unchanged in the promise.
At the moment if we pass false or undefined to cancel, in the promise resolution we have true