Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Calling $mdDialog.hide with an empty string resolves to the string 'true' #4150

@ddimitrop

Description

@ddimitrop

See codepen

http://codepen.io/anon/pen/oXOyjz

Problem at line:

.remove(reason || SHOW_CLOSED, false)

If 'reason' (which is the value returned by the dialog) is empty, the expression remove(reason || SHOW_CLOSED, false) passes SHOW_CLOSED (='true') to the caller.

Metadata

Metadata

Assignees

Labels

g3: reportedThe issue was reported by an internal or external product team.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions