This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(subheader): Fix thrown error when using md-subheader with ng-if and ng-repeat. #4171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
the
pr: merge ready
topherfangio
force-pushed
the
fix-subheader-2650
branch
from
ab5dc48 to
acb29b4
Compare
topherfangio
changed the title
topherfangio
force-pushed
the
fix-subheader-2650
branch
from
ff6a2f1 to
acb29b4
Compare
topherfangio
added
needs: review
|
@topherfangio - I see the references to the issues, but what was the issue/problem? How do the tests prove the change is valid? |
ThomasBurleson
added
in progress
…nd ng-repeat. When used with `ng-if` or `ng-repeat`, the `md-subheader` was not able to properly clone itself when creating a sticky because it only had a comment tag. Delay initialization until after the `ng-if`/`ng-repeat` has finished before attempting to create the clone. fixes #2650, fixes #2980
topherfangio
force-pushed
the
fix-subheader-2650
branch
from
acb29b4 to
f25a8f6
Compare
topherfangio
added
pr: merge ready
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
…nd ng-repeat. When used with `ng-if` or `ng-repeat`, the `md-subheader` was not able to properly clone itself when creating a sticky because it only had a comment tag. Delay initialization until after the `ng-if`/`ng-repeat` has finished before attempting to create the clone. fixes angular#2650. fixes angular#2980. closes angular#4171.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with
ng-iforng-repeat, themd-subheaderwas not able to properlyclone itself when creating a sticky because it only had a comment tag. Delay
initialization until after the
ng-if/ng-repeathas finished before attemptingto create the clone.
fixes #2650, fixes #2980