This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(mdToolbar): Better fix for ng-if that allows ng-controller. #4423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After modifying the `<md-toolbar>` directive to allow both `md-scroll-shrink` and `ng-if`, we accidentally broke support for also using `ng-controller` as well as some layout problems due to the transclusion and a wrapping `<div>`. This reverts those changes but still allows for `ng-if` to work. Fixes #4144.
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
After modifying the `<md-toolbar>` directive to allow both `md-scroll-shrink` and `ng-if`, we accidentally broke support for also using `ng-controller` as well as some layout problems due to the transclusion and a wrapping `<div>`. This reverts those changes but still allows for `ng-if` to work. Fixes angular#4144. Closes angular#4423.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After modifying the
<md-toolbar>directive to allow bothmd-scroll-shrinkandng-if, we accidentally broke supportfor also using
ng-controlleras well as some layout problemsdue to the transclusion and a wrapping
<div>. This revertsthose changes but still allows for
ng-ifto work.Also updated docs with some extra info.
Fixes #4414.