md-select forces number-like string values to be numbers

[richardszalay]

PR #3560 introduced a breaking change that causes number-like values (eg. "0930") to be parsed as numbers.

The problem is the PR uses isNaN(value) to determine whether the value is a string, but isNaN("0930") returns true. I propose modifying this to use typeof value == "number" instead, as it resolves correctly against the above test values.

[richardszalay]

Update: while a breaking change was definitely introduced in 0.11.0, I'm actually repro'ing the problem even without #3560.

I'm going to work around it for now, but if anyone else wants to take a look here's a test:

it('should not convert number-like strings to numbers', inject(function($compile, $rootScope) {
    $rootScope.value = 1;
    $compile('<md-select ng-model="value">' +
      '<md-option ng-repeat="value in [\'01\', \'02\', \'03\']" value="{{value}}">{{value}}</md-option>' +
      '</md-select>')($rootScope);
    $rootScope.$digest();
    expect($rootScope.value).toBe('01');
  }));

+1 I've just started seeing this as well for eg. "3030.57" after upgrading to 0.11.0

[mjhasbach]

+1

@richardszalay You might consider updating the issue description from:

PR #3560 introduced a breaking change that causes number-like values (eg. "0930") to be parsed as strings.

to

PR #3560 introduced a breaking change that causes number-like values (eg. "0930") to be parsed as numbers.

[richardszalay]

Well caught @mjhasbach. Corrected!

++1 this just bit me again! My previous workaround was flawed. I think the only safe way to go is add a letter to the value so it's never converted to a number..

[rschmukler]

Demo codepen here.

We should likely revert the change introduced as it is counter to how Angular's native select behaves. With angular's select, the value attribute is always a string, and ng-value can be used for any non-string value. Docs here

[richardszalay]

@rschmukler I wouldn't be so hasty in closing the issue - as I mentioned in my follow up comment, I was able to reproduce the bug even without the changes introduced by #3560.