This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): fixes the sizing math #7015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -545,7 +545,7 @@ function MdTabsController ($scope, $element, $window, $mdConstant, $mdTabInkRipp | |||
| function updatePagingWidth() { | |||
| var width = 1; | |||
| angular.forEach(getElements().dummies, function (element) { | |||
| width += Math.ceil(element.offsetWidth); | |||
| width += Math.ceil(element.getBoundingClientRect().width); | |||
There was a problem hiding this comment.
Add a comment saying why you use this specifically?
ThomasBurleson
added
the
in progress
|
Please assign back to me when ready. |
ThomasBurleson
added
pr: merge ready
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this pull request
Feb 9, 2016
Fixes angular#6212. Closes angular#7015.
|
This fix worked when the tabs initializes, showing the 2 tabs i have. But when clicking on the second tab, it gets bigger (by 2px on firefox and 7px on safari), but the calculation is using the dummy which remained the same size. |
|
@danielgranat Same thing, and to all that last tab is not visible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6212
@jelbourn @ThomasBurleson