This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): Change updatePagingWidth to handle subpixel tab width #6737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updatePagingWidth now uses getBoundingClientRect() instead of offsetWidth to compute total width of tabs. offsetWidth returns only the integer part of the tab width which can cause the pagination-wrapper to be to narrow, causing the last tab to wrap and become not visible. Addresses angular#5439
|
👍 |
ThomasBurleson
added
the
pr: merge ready
|
@mcosand - lgtm |
|
This issue is closed as part of our ‘Surge Focus on Material 2' efforts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updatePagingWidth now uses getBoundingClientRect() instead of offsetWidth
to compute total width of tabs. offsetWidth returns only the integer part
of the tab width which can cause the pagination-wrapper to be to narrow,
causing the last tab to wrap and become not visible.
Addresses #5439