md-select throws "Cannot read property 'selectedLabels' of undefined", suggest existence check first

[jaGarcia]

Occurred in 1.0.4 and 1.0.5 that I've tested.

I have a function that updates the div the md-select is in with HTML pulled from the server. It looks like the old DOM element is being swapped out before this latent function fires. Suggest perhaps checking the existance first:

    function announceClosed(opts) {
      var mdSelect = opts.selectCtrl;
      if (mdSelect) {
        var menuController = opts.selectEl.controller('mdSelectMenu');
        **if(menuController) {**
             mdSelect.setLabelText(menuController.selectedLabels());
             mdSelect.triggerClose();
        **}**
      }
    }

[topherfangio]

Any chance you can provide a Codepen demo of how you are getting the error? It's definitely an easy fix, but I'd like to write a test to go with it, and the demo would certainly help.

[jaGarcia]

I gave it a quick shot but can't seem to trigger it :(
http://codepen.io/anon/pen/VeqWxO

If you go here and click "Sort $ High to Low" you'll see it trigger the error.

I know it's not what you need to implement/write a test, but maybe you'll see something I don't...

I'm hitting my server, pulling HTML fragment, and then "compiling" it on the front end to enable the angular components in the fragment to be enabled

[topherfangio]

@jaGarcia Thanks for the link. I will try to dig in soon and see if I can write a failing test.

[gigadie]

I had the same issue today for the first time. Upgrading to 1.0.5, until today using 1.0.1 didn't cause the issue.

[dohomi]

+1

+1

[patrickmichalina]

👍