Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Button ripple vertical positioning #725

Closed
ajoslin opened this issue Nov 21, 2014 · 3 comments
Closed

Button ripple vertical positioning #725

ajoslin opened this issue Nov 21, 2014 · 3 comments
Assignees
Milestone

Comments

@ajoslin
Copy link
Contributor

ajoslin commented Nov 21, 2014

The ripple will always be created in the vertical center of the button, even when clicking on the bottom or top edge of a button.

See https://material.angularjs.org/#/demo/material.components.button and click a corner of one of the buttons.

This is a much more noticeable bug when having taller buttons.

@ajoslin ajoslin added this to the 0.6.0-rc2 milestone Nov 21, 2014
@nmabhinandan
Copy link

The problem is only in circular buttons. Rectangle buttons are working fine.

robertmesserle added a commit that referenced this issue Nov 22, 2014
Switches FAB ripples back to non-centered.
Resolves vertical alignment issue.  Closes #725.
Cleans up code tabbing in ripple.js.
Adds function comments in ripple.js.
@nvurgaft
Copy link

@robertmesserle
Copy link
Contributor

The fix is on the 'ripple-vertical-fix' branch, and has not been merged into master yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants