This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): Fix NPE by checking for controller existence. #7560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the select could be removed from the DOM before some of the cleanup code was executed. This caused a `.controller()` call to return `null`, but we did not check for existence before using the controller which resulted in null pointer exception. Fixes angular#7079.
topherfangio
added
needs: review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the select could be removed from the DOM before some
of the cleanup code was executed. This caused a
.controller()callto return
null, but we did not check for existence before usingthe controller which resulted in null pointer exception.
Fixes #7079.