Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

subheader: tests for subheader are useless. #8504

@devversion

Description

@devversion

Currently the subheader tests are completely meaningless and useless.

There are several issues:

  • We're not injecting our material.components.subheader module
  • We're mocking the complete $mdSticky service.

So at the moment we're testing things like ng-if with the $mdSticky mock and without our actual directive, because it can't be loaded.

This is actually a test, which just tests the standard AngularJS directive.

I'm working on some improvements on those tests.

Metadata

Metadata

Assignees

Labels

P2: requiredIssues that must be fixed.has: Pull RequestA PR has been created to address this issue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions