colors: does not support dashes in theme names #8755
Comments
@zeruel01 actually this is an interpolation error of mdColors which splits the expressions by @topherfangio do you think we should support this edge case? |
i see, let me check i still cant understand what did you change, so its a naming issue ? |
@EladBezalel Correct me if I am wrong, but this appears to fail on any theme that has a dash in it. I think we should support themes like Am I understanding the problem correctly? |
We do support two word themes, but only two words 😅 |
weird, i wanted to use all the colors included deep-purple or renamed ones |
The problem with your code is that we currently doesn't support dashes in theme name with mdColors deep-purple and others are available as palettes |
@EladBezalel - we should either fix this OR document it. |
@ThomasBurleson fixing it will make us write a recursive function that takes each part and check if it's a theme, we can do it but it sounds like an overkill to me. docs is another option :) |
overkill is the best kill 💥 |
Actual behavior:
i was looking for this issue (i got the same) mdColors: Dynamic expression breaks when theme is specified #8720
and it got solved, but i wanted to have dynamic themes and it broke
changing a theme should override the colors of the md-colors based on their values ej { 'background': 'primary-100' } should be a primary of my current theme
CodePen or Steps to reproduce the issue: *
http://codepen.io/zeruel01/pen/ezZVQZ
i got this error i dont know if it helps
http://prntscr.com/bg09k1
Additional Information:
could you help me alittle maybe im missing something ? or it really is an error
The text was updated successfully, but these errors were encountered: