New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing JSHint warnings #9153

Closed
crisbeto opened this Issue Jul 27, 2016 · 5 comments

Comments

@crisbeto
Member

crisbeto commented Jul 27, 2016

We have a lot of pretty trivial warnings from JSHint. It would be nice to have them resolved at some point.

@crisbeto crisbeto self-assigned this Jul 27, 2016

@crisbeto crisbeto added this to the - Backlog milestone Jul 27, 2016

crisbeto added a commit to crisbeto/material that referenced this issue Aug 21, 2016

chore(colors, dialog, subheader, layout, theming, animate): fix linte…
…r warnings

Fixes the linter warnings in: colors, dialog, subheader, layout, theming, animate.

Referencing angular#9153.

jelbourn added a commit that referenced this issue Aug 23, 2016

chore(colors, dialog, subheader, layout, theming, animate): fix linte…
…r warnings (#9367)

Fixes the linter warnings in: colors, dialog, subheader, layout, theming, animate.

Referencing #9153.

crisbeto added a commit to crisbeto/material that referenced this issue Aug 23, 2016

chore(): fix more jshint warnings
Another batch of minor jshint warning fixes.

Referencing angular#9153.

kara added a commit that referenced this issue Sep 8, 2016

chore(): fix more jshint warnings (#9387)
Another batch of minor jshint warning fixes.

Referencing #9153.

Frank3K added a commit to Frank3K/material that referenced this issue Sep 11, 2016

chore(): fix more jshint warnings (angular#9387)
Another batch of minor jshint warning fixes.

Referencing angular#9153.

@Splaktar Splaktar self-assigned this Nov 21, 2017

@Splaktar Splaktar modified the milestones: - Backlog, 1.1.6 Nov 21, 2017

@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018

@Splaktar Splaktar modified the milestones: 1.1.7, 1.1.8 Jan 29, 2018

@5earle

This comment has been minimized.

Contributor

5earle commented Jan 29, 2018

Good day. i am a student studying open source at Seneca college, and would like to take a go at this project if it is still available

@Splaktar

This comment has been minimized.

Member

Splaktar commented Jan 30, 2018

@5earle we would be happy to review your PR to solve the remaining JSHint issues. Please make sure to limit the scope of the changes to the bare minimum of what needs to be changed to get JSHint passing.

@5earle

This comment has been minimized.

Contributor

5earle commented Feb 3, 2018

@Splaktar there is stuff like:

W069 Line 1497, Col 39 ['onCloseSuccess'] is better written in dot notation.
W043 Line 296, Col 17 Bad escaping of EOL. Use option multistr if needed.

would fixing these be an issue?

@5earle 5earle referenced this issue Feb 4, 2018

Closed

Fix(JSHint)Warnings #11107

3 of 3 tasks complete

@5earle 5earle referenced this issue Feb 6, 2018

Merged

Fix jshint warnings #11109

3 of 3 tasks complete
@Splaktar

This comment has been minimized.

Member

Splaktar commented Feb 11, 2018

@5earle sorry for the delay. We should disable that rule as it is designed for supporting ES3. Those escapes are just fine in ES5, which we target.

For the second, I would also disable that rule.

You can add the following to .jshintrc to fix both of these:

  "sub": true,
  "multistr": true,
@Splaktar

This comment has been minimized.

Member

Splaktar commented Mar 16, 2018

Fixed in cec409a.

@Splaktar Splaktar closed this Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment