Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

mdDialog: md-dialog-fullscreen class is not removed after closing pre-rendered dialog #9276

@Looooong

Description

@Looooong

Actual Behavior:

  • What is the issue? * The pre-rendered dialog is configured with contentElement and fullscreen: true. After the dialog is closed, the md-dialog-fullscreen class is not removed from the md-dialog element.
  • What is the expected behavior? md-dialog-fullscreen class should be removed from md-dialog element, either after closing the dialog or re-open the dialog with contentElement and fullscreen: false.

CodePen (or steps to reproduce the issue): *

  • CodePen Demo which shows your issue:
  • Details: Steps to reproduce:
  1. Configure the dialog with contentElement and fullscreen: true.
  2. Open the dialog.
  3. Close the dialog.
  4. Reconfigure the dialog with contentElement and fullscreen: false.
  5. Open the dialog. Now the dialog is still in fullscreen mode because md-dialog-fullscreen is not removed,

Angular Versions: *

  • Angular Version: 1.5.x
  • Angular Material Version: 1.1.0-rc.5

Additional Information:

  • Browser Type: * Google Chrome
  • Browser Version: * 52.0.2743.116 (64-bit)
  • OS: * Ubuntu 16.02 LTS
  • Stack Traces:

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.

Metadata

Metadata

Assignees

Labels

P4: minorMinor issues. May not be fixed without community contributions.has: Pull RequestA PR has been created to address this issuetype: bug

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions