Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix(panel): Element reference error #9374

Closed
bradrich opened this issue Aug 22, 2016 · 0 comments
Closed

fix(panel): Element reference error #9374

bradrich opened this issue Aug 22, 2016 · 0 comments
Assignees
@bradrich
Labels
has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed.
Milestone
1.1.1

Comments

@bradrich
Copy link
Contributor

Actual Behavior:

  • What is the issue? * In PR feat(mdPanel): Wrapper and Panel elements referenced in the MdPanelRef #9231, I made the panelContainer and panelEl references public within the API. When I went through and added the deprecation notices to the addClass, removeClass, and toggleClass methods, I overlooked the fact that panelContainer and panelEl were public and I left them private. Tests didn't fail because of the defined exceptions.
  • What is the expected behavior? panelContainer and panelEl need to be public everywhere.

CodePen (or steps to reproduce the issue): *

  • CodePen Demo which shows your issue: N/A
  • Details: N/A

Angular Versions: *

  • Angular Version: Latest
  • Angular Material Version: Latest

Additional Information:

  • Browser Type: * All
  • Browser Version: * All
  • OS: * All
  • Stack Traces: N/A

Ping @ErinCoughlan
@bradrich bradrich self-assigned this Aug 22, 2016
bradrich added a commit to bradrich/material that referenced this issue Aug 22, 2016
@bradrich
fix(panel): Element reference error
0373338 
All references to `panelContainer` and `panelEl` have been verified as public, and the methods that contained the offending references have been corrected.

Fixes angular#9374

Ping @ErinCoughlan
@bradrich bradrich mentioned this issue Aug 22, 2016
Merged
@ThomasBurleson ThomasBurleson added this to the 1.1.1 milestone Aug 22, 2016
@ThomasBurleson ThomasBurleson added the P2: required Issues that must be fixed. label Aug 22, 2016
@bradrich bradrich added the has: Pull Request A PR has been created to address this issue label Aug 22, 2016
jelbourn pushed a commit that referenced this issue Aug 23, 2016
@bradrich @jelbourn
fix(panel): Element reference error (#9375)
6383b52 
All references to `panelContainer` and `panelEl` have been verified as public, and the methods that contained the offending references have been corrected.

Fixes #9374

Ping @ErinCoughlan
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradrich bradrich

Labels
has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed.
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@ThomasBurleson @bradrich