This repository was archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
chips: remove icon is larger in 1.1.0 vs 1.0.9 #9619
Copy link
Copy link
Closed
Labels
- Breaking ChangeP2: requiredIssues that must be fixed.Issues that must be fixed.has: Pull RequestA PR has been created to address this issueA PR has been created to address this issueresolution: fixedseverity: regressionThis issue is related to a regressionThis issue is related to a regressiontype: bugtype: spec alignmentFor issues related to aligning with the Material Design SpecFor issues related to aligning with the Material Design Spec
Milestone
Description
Actual Behavior:
What is the issue? *
The remove icons for md-chips are 24px in the 1.1 version. They used to be 18px.
The change was not intentional but due to the min-width, min-height properties that have now been added in md-icon.
All references to md-icon in the code (where they override width and height) need to be fixed.What is the expected behavior?
The remove icons should be 18px. This is what this code is trying to do:
https://github.com/angular/material/blob/master/src/components/chips/chips.scss#L130
This needs to include now:
min-height: $chip-delete-icon-size;
min-width: $chip-delete-icon-size;
I believe that the same problem may be happening in other places like here:
material/src/components/list/list.scss
Line 62 in dfc9ae7
width: $list-item-dense-primary-icon-width; |
CodePen (or steps to reproduce the issue): *
CodePen Demo which shows your issue:
https://material.angularjs.org/latest/demo/chipsDetails:
Inspect the 'X' icons
Angular Versions: *
Angular Version:
1.5.5- `Angular Material Version: 1.1.1
Additional Information:
Browser Type:
Chrome- `Browser Version: 53
- `OS: Linux
Stack Traces:
Shortcut to create a new CodePen Demo.
Note: *
indicates required information. Without this information, your issue may be auto-closed.
Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.
Splaktar
Metadata
Metadata
Assignees
Labels
- Breaking ChangeP2: requiredIssues that must be fixed.Issues that must be fixed.has: Pull RequestA PR has been created to address this issueA PR has been created to address this issueresolution: fixedseverity: regressionThis issue is related to a regressionThis issue is related to a regressiontype: bugtype: spec alignmentFor issues related to aligning with the Material Design SpecFor issues related to aligning with the Material Design Spec