Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

mdPanel - integrate with $mdCompiler changes #9757

@devversion

Description

@devversion
  • Recently we made some refactoring on the $mdCompiler and it now supports contentElements

Task 1

Rather than manually removing the element from the DOM, the panel should use the cleanup method, to integrate with the contentElement functionality.

const compileData = $mdCompiler.compile(...);

/* Removes or restores the element */
compileData.cleanup();

Task 2

To properly support contentElements, the transition classes need to be reverted before calling the cleanup function.

You can either

  • Manually remove the transition classes
  • Reversely run the $animate runner.

Task 3

Add documentation to the panel, to let users know how they can use a contentElement.


This currently blocks the port of the dialog to the panel (#9675).

Metadata

Metadata

Assignees

Labels

P2: requiredIssues that must be fixed.has: Pull RequestA PR has been created to address this issue

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions