Remove @constructor jsdoc on MdChipsCtrl to prevent Closure compiled removal of $inject value

[tsle]

Actual Behavior:
Remove @constructor in jsdoc for angular chips.
The issue that this fixes:
When compiled by closure, the $inject assignment to the constructor is removed, and as a result, in compiled mode, injection error occurs due to obfuscation and no $inject property.

Angular Versions: * -
Angular Material Version:` 1.1

Additional Information:

• Browser Type: *
• Browser Version: *
• OS: *
• Stack Traces:

---

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.

[crisbeto]

While we're at it, perhaps this is a problem in other places as well? We're using that annotation in a few more places.

[tsle]

So far I've only seen this error on in the chips component, but it's
possible it is elsewhere too.

On Wed, Oct 5, 2016 at 10:27 AM, Kristiyan Kostadinov <
notifications@github.com> wrote:

While we're at it, perhaps this is a problem in other places as well?
We're using that annotation a few more places.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9758 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACu3hsD-fQNDi78sW-r41vXesA9PfSxLks5qw94fgaJpZM4KPB6W
.

[jelbourn]

A nice alternative to removing @constructor might be to make the ngInject tool output
WhateverCtrl['$inject'] instead of WhateverCtrl.$inject; Closure Compiler always preserves properties defined with the former syntax.

[crisbeto]

After playing around with it, it looks like it happens in the cases where @constructor is the only directive on the line. We have a bunch of cases that use it as ngInject @constructor and those work properly (probably because it's considered invalid). I'm still looking for a way to do this automatically since keeping these comments in sync will get annoying.

EDIT: Changing the notation seem to do the trick.