feat(panel): Panel provider #10215

Merged
merged 1 commit into from Jan 4, 2017

Projects

None yet

4 participants

@bradrich
Member
bradrich commented Jan 4, 2017

Fixes #10006 - Allows users to be able to add the $mdPanelProvider to the config block
of their application. They can use this provider to create one or more
configurations for upcoming panel elements.

Fixes #10162 - Alters the configuration of a panel with a user-defined id that has been
saved when that panel is re-created. This will update the configuration properties such
as panelClass, etc.

@bradrich bradrich self-assigned this Jan 4, 2017
@bradrich bradrich requested a review from ThomasBurleson Jan 4, 2017
@ThomasBurleson

Looks very good... only one minor change needed.

src/components/panel/panel.js
+ * @return {!Object}
+ */
+function getAllPresets() {
+ return _presets;
@ThomasBurleson
ThomasBurleson Jan 4, 2017 Contributor

This should be a clone of the presets so the API is readonly.

@ThomasBurleson ThomasBurleson added this to the 1.1.2 milestone Jan 4, 2017
@bradrich bradrich feat(panel): Panel provider
Fixes #10006 - Allows users to be able to add the $mdPanelProvider to the config block
of their application. They can use this provider to create one or more
configurations for upcoming panel elements.

Fixes #10162 - Alters the configuration of a panel with a user-defined id that has been
saved when that panel is re-created. This will update the configuration properties such
as panelClass, etc.
a782e43
@bradrich
Member
bradrich commented Jan 4, 2017

@ThomasBurleson We are GTG!

@ThomasBurleson
Contributor

lgtm

@kara kara added needs: merge and removed needs: presubmit labels Jan 4, 2017
@kara kara merged commit a169f6f into master Jan 4, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment