Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(panel): Panel provider #10215

Merged
merged 1 commit into from
Jan 4, 2017
Merged

feat(panel): Panel provider #10215

merged 1 commit into from
Jan 4, 2017

Conversation

bradrich
Copy link
Contributor

@bradrich bradrich commented Jan 4, 2017

Fixes #10006 - Allows users to be able to add the $mdPanelProvider to the config block
of their application. They can use this provider to create one or more
configurations for upcoming panel elements.

Fixes #10162 - Alters the configuration of a panel with a user-defined id that has been
saved when that panel is re-created. This will update the configuration properties such
as panelClass, etc.

@bradrich bradrich self-assigned this Jan 4, 2017
@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ labels Jan 4, 2017
Copy link
Contributor

@ThomasBurleson ThomasBurleson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good... only one minor change needed.

* @return {!Object}
*/
function getAllPresets() {
return _presets;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a clone of the presets so the API is readonly.

@ThomasBurleson ThomasBurleson added this to the 1.1.2 milestone Jan 4, 2017
Fixes #10006 - Allows users to be able to add the $mdPanelProvider to the config block
of their application. They can use this provider to create one or more
configurations for upcoming panel elements.

Fixes #10162 - Alters the configuration of a panel with a user-defined id that has been
saved when that panel is re-created. This will update the configuration properties such
as panelClass, etc.
@bradrich bradrich force-pushed the feat/panel-provider branch from 0db9879 to a782e43 Compare January 4, 2017 17:03
@bradrich
Copy link
Contributor Author

bradrich commented Jan 4, 2017

@ThomasBurleson We are GTG!

@ThomasBurleson
Copy link
Contributor

lgtm

@kara kara added pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels Jan 4, 2017
@kara kara merged commit a169f6f into master Jan 4, 2017
davidenochk pushed a commit to davidenochk/material that referenced this pull request Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants