Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(mdGesture): allow to change maxClickDistance through $mdGestureProvider.setMaxClickDistance #10498

Merged
merged 1 commit into from
May 10, 2017

Conversation

mprokopowicz
Copy link
Contributor

on some touch devices tap is often lost due to small finger movements

fixes #10492

…rovider.setMaxClickDistance

on some touch devices tap is often lost due to small finger movements

fixes angular#10492
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 15, 2017
@mprokopowicz
Copy link
Contributor Author

Can someone of maintarners explain me why the build failed? Tests were pasing on my local machine.

@EladBezalel
Copy link
Member

@devversion any idea?

@devversion
Copy link
Member

@EladBezalel Looks like code.angularjs.org was at this time down. Restarted the builds and it seems to work.

@mprokopowicz
Copy link
Contributor Author

Any chances to merge it before 1.1.4?

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also shouldn't be a breaking change.

@ThomasBurleson ThomasBurleson added this to the 1.1.5 milestone May 8, 2017
@kara kara added pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels May 10, 2017
@kara kara merged commit 29ef510 into angular:master May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdGesture: allow to change default maxClickDistance value in gesture provider
6 participants