Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Don't assume that the scrollMask is present when closing the md-dialog #10708

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

janvandenberg
Copy link
Contributor

Fixed an issue where md-dialog contains md-autocomplete elements. These elements remove the scroll mask before the dialog is closed, resulting in an exception when closing the dialog. This a symptom fix. I don't assume that the mask is still there before I try to delete it. But now the dialog closed properly and no errors.

…se elements remove the md-scroll-mask before the dialog is closed, resulting in an exception when closing the dialog. This a symptom fix. I don't assume that the mask is still there before I try to delete it.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label May 31, 2017
@janvandenberg
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels May 31, 2017
@ThomasBurleson
Copy link
Contributor

@janvandenberg - lgtm

@ThomasBurleson ThomasBurleson added this to the 1.1.5 milestone Jun 12, 2017
@kara kara merged commit 590b684 into angular:master Jul 18, 2017
@kara kara added pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants