This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(theming): don't assume selector corresponds to expression #10818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the theming code assume that if you have a selector like "md-primary", all of the expressions therein will only be in terms of "primary". This was not the case, causing one style to leave an unevaluated expression in the css output. This change *also* deletes the troublesome style because it seemed to be incorrect anyway. Fixes angular#10793
googlebot
added
the
cla: yes
|
@EladBezalel - as our ngM1 Theming dev, can you review these changes and validate? |
EladBezalel
approved these changes
Aug 3, 2017
|
LGTM |
jelbourn
added
needs: presubmit
and removed
needs: review
Splaktar
added
pr: merge ready
Splaktar
added
P2: required
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the theming code assume that if you have a selector
like "md-primary", all of the expressions therein will only be in terms
of "primary". This was not the case, causing one style to leave an
unevaluated expression in the css output.
This change also deletes the troublesome style because it seemed to be
incorrect anyway.
Fixes #10793