This repository was archived by the owner on Sep 5, 2024. It is now read-only.
docs(datepicker): follow Material Design guidelines for messages #11149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
approved these changes
Mar 4, 2018
| <div ng-message="mindate">Date is too early!</div> | ||
| <div ng-message="maxdate">Date is too late!</div> | ||
| <div ng-message="valid">Use a valid date format</div> | ||
| <div ng-message="required">This date is required</div> |
There was a problem hiding this comment.
Let's get rid of the required message since we don't have required on the md-datepicker. That doesn't make for a good example for others to follow :)
Splaktar
added
pr: merge safe
pr: lgtm
|
Please add "Closes #11007" to the footer of your commit message as detailed in the commit message guidelines. |
3 tasks
Splaktar
added
needs: squash commits
and removed
pr: merge ready
Splaktar
added
pr: merge ready
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
Splaktar
pushed a commit
that referenced
this pull request
Jul 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
Documentation changes
What is the current behavior?
Issue Number: #11007
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Closes #11007