Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Using 0 for md-chip-append-delay causes the directive to convert 0 to 300ms due to a bad if check. This is a regression caused by the chips a11y updates in 1.1.2.

Issue Number:
Fixes #10408

What is the new behavior?

Setting md-chip-append-delay to 0 now removes the delay completely as expected.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Thanks to @mgol for the report and corrected code snippet.

@Splaktar Splaktar added type: bug a11y This issue is related to accessibility pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression P2: required Issues that must be fixed. labels Mar 13, 2018
@Splaktar Splaktar added this to the 1.1.8 milestone Mar 13, 2018
@Splaktar Splaktar self-assigned this Mar 13, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 13, 2018
@mmalerba mmalerba merged commit 1f6d1b2 into master Mar 14, 2018
@Splaktar Splaktar deleted the fixChipAppendDelay branch March 14, 2018 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chips: md-chip-append-delay treats 0 as the default value
3 participants