Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

From #9627 (comment):

mdDialog causes thread blocking issues when traversing large DOM trees (in this case, SharePoint 2013) using the walkDOM(element) method. Thread is blocked for approximately 30-40 seconds while aria-hidden attributes are applied.

Issue Number:
Closes #9627.

What is the new behavior?

From #9627 (comment):

mdDialog should open/close without blocking the UI thread due to traversing the DOM tree to apply aria-hidden attributes.

From #9627 (comment)

collect dom elements and then apply any changes instead applying attributes on the fly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

(cherry picked from commit 44a2d2d)
This retains the fix for live regions from #10807.

As pointed out by @aivaras-b in #10552 (comment), this fix was merged into the release/1.1.1 branch and then never merged to master.

@Splaktar Splaktar added the type: performance This issue is related to performance label Mar 26, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Mar 26, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Mar 26, 2018
@Splaktar Splaktar changed the title fix(dialog): thread blocking during large DOM traversals (#10552) fix(dialog): thread blocks during large DOM traversals (#10552) Mar 26, 2018
@Splaktar Splaktar changed the title fix(dialog): thread blocks during large DOM traversals (#10552) fix(dialog): thread blocks during large DOM traversals Mar 26, 2018
@angular angular deleted a comment from googlebot Mar 26, 2018
@Splaktar Splaktar added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer P3: important Important issues that really should be fixed when possible. and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Mar 26, 2018
@Splaktar Splaktar force-pushed the improveDialogPerformance branch 2 times, most recently from f1e415d to c629441 Compare March 26, 2018 22:33
@Splaktar Splaktar force-pushed the improveDialogPerformance branch from c629441 to 4fb724e Compare March 26, 2018 22:34
@josephperrott josephperrott merged commit 9086b54 into master Mar 29, 2018
@Splaktar Splaktar deleted the improveDialogPerformance branch March 30, 2018 01:46
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: performance This issue is related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdDialog: issues with open/close on traversal of large DOM trees
4 participants