-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(layout): allow flex-offset to be a child of layout-margin #11330
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! It looks good other than the one space issue that I mentioned.
src/core/style/layout.scss
Outdated
@@ -45,7 +45,7 @@ | |||
@if $s != '' { $suffix : '#{$s}-#{$i * 5}'; } | |||
@else { $suffix : '#{$i * 5}'; } | |||
|
|||
$offsets : '.offset-#{$suffix}, .flex-offset-#{$suffix}'; | |||
$offsets : '.offset-#{$suffix}, .flex-offset-#{$suffix}, .layout-margin .flex-offset-#{$suffix}, .layout-margin .offset-#{$suffix}'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the extra space at the start of the line breaks the alignment of the code here? Can you please remove that one space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 6e4b733
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds .layout-margin to the layout-offset selector for more specificity
Fixes #11328
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The CSS class
.layout-margin
overwrites the margin-left declaration from.flex-offset-*
, so it doesn't get offset to the right.Issue Number: #11328
What is the new behavior?
.flex-offset
now includes.layout-margin
in it's CSS selector to increase specificity and not have it's margin overwritten by.layout-margin
when it is a child of.layout-margin
Does this PR introduce a breaking change?
Other information