Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:
Relates to babel/minify#878
Relates to #11165

What is the new behavior?

  • avoid creating variables in a block when they are used outside
  • instead create them directly in the function block they are hoisted to
  • fix typos
  • fix lint issues and whitespace
  • improve JSDoc

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

avoid creating variables in a block when they are used outside
instead create them directly in the function block they are hoisted to
fix typos
fix lint issues and whitespace
improve JSDoc

Relates to babel/minify#878
@Splaktar Splaktar added type: conflict P4: minor Minor issues. May not be fixed without community contributions. labels Jun 29, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Jun 29, 2018
@Splaktar Splaktar self-assigned this Jun 29, 2018
@Splaktar Splaktar requested a review from mgol June 29, 2018 18:25
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 29, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jul 4, 2018
@mmalerba mmalerba merged commit 0ed110b into master Jul 9, 2018
Splaktar added a commit that referenced this pull request Jul 31, 2018
…11351)

avoid creating variables in a block when they are used outside
instead create them directly in the function block they are hoisted to
fix typos
fix lint issues and whitespace
improve JSDoc

Relates to babel/minify#878
Splaktar added a commit that referenced this pull request Aug 2, 2018
…11351)

avoid creating variables in a block when they are used outside
instead create them directly in the function block they are hoisted to
fix typos
fix lint issues and whitespace
improve JSDoc

Relates to babel/minify#878
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants