Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

build(gulp-uglify): use new syntax for preserving some comments #11365

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jul 10, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The gulp-uglify update broke the build-js task due to a breaking change to the gulp-uglify API.

Issue Number:
N/A

What is the new behavior?

Fixed build broken by gulp-uglify update.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Example of a broken build: https://travis-ci.org/angular/material/jobs/401935217

@Splaktar Splaktar added type: build pr: merge ready This PR is ready for a caretaker to review P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge safe labels Jul 10, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Jul 10, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jul 10, 2018
@Splaktar
Copy link
Contributor Author

The only Travis CI failure here appears to be due to a bad or in-progress AngularJS SNAPSHOT. It can be ignored.

@jelbourn jelbourn merged commit 607dd02 into master Jul 10, 2018
@Splaktar Splaktar deleted the fixGulpUglify branch July 10, 2018 20:43
Splaktar added a commit that referenced this pull request Jul 31, 2018
Splaktar added a commit that referenced this pull request Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review type: build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants