Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(card): replace problematic share icon #11370

Merged
merged 1 commit into from
Jul 12, 2018
Merged

docs(card): replace problematic share icon #11370

merged 1 commit into from
Jul 12, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • icon didn't take on white color in dark theme
  • icon doesn't match latest updates to Material Design Icons

Issue Number:
Fixes #9992

What is the new behavior?

Icon matches share icon from MD icons and takes on theme colors correctly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Before:
screen shot 2018-07-12 at 5 09 49 pm

After:
screen shot 2018-07-12 at 5 09 34 pm

@Splaktar
docs(card): replace problematic share icon
f57aa4f 
icon didn't take on white color in dark theme
icon doesn't match latest updates to Material Design Icons

Fixes #9992
@Splaktar Splaktar added type: docs P4: minor Minor issues. May not be fixed without community contributions. type: spec alignment For issues related to aligning with the Material Design Spec labels Jul 12, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Jul 12, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jul 12, 2018
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Jul 12, 2018
jelbourn
jelbourn approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 03e7c22 into master Jul 12, 2018
@Splaktar Splaktar deleted the fixShareIcon branch July 12, 2018 21:16
Splaktar added a commit that referenced this pull request Jul 31, 2018
@Splaktar
docs(card): replace problematic share icon (#11370)
27959a1 
icon didn't take on white color in dark theme
icon doesn't match latest updates to Material Design Icons

Fixes #9992
Splaktar added a commit that referenced this pull request Aug 2, 2018
@Splaktar
docs(card): replace problematic share icon (#11370)
4031f64 
icon didn't take on white color in dark theme
icon doesn't match latest updates to Material Design Icons

Fixes #9992
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jelbourn jelbourn jelbourn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jelbourn jelbourn

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: docs type: spec alignment For issues related to aligning with the Material Design Spec
Projects
None yet
Milestone
1.1.11
Development

Successfully merging this pull request may close these issues.

docs(card): share icon button in dark mode doesn't match other icons in demo
3 participants
@Splaktar @jelbourn @googlebot