Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(autocomplete): announce when an item is selected from the dropdown #11403

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When selecting an item from the dropdown, screen readers do not notify the user that a selection was made.

Issue Number:
Fixes #10837

What is the new behavior?

  • announce when an item is selected from the dropdown
  • make sure that this message can be overridden in non-English locales
  • fix some lint warnings and style issues
  • add and fix JSDoc

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

make sure that this message can be overridden in non-English locales
fix some lint warnings and style issues
add and fix JSDoc

Fixes #10837
@Splaktar Splaktar added type: enhancement a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Aug 11, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Aug 11, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Aug 11, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Aug 11, 2018
@mmalerba mmalerba merged commit e56424e into master Aug 14, 2018
@Splaktar Splaktar deleted the autocompleteAnnounceSelected branch August 14, 2018 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete: when selecting an entry, ChromeVox screen reader does not notify user of the selection made
3 participants